gEDA-dev: [pcb] Possible bug in prompt_for() in GTK HID

Tomaž Šolc tomaz.solc at tablix.org
Sat Mar 8 14:44:12 EST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

When browsing through PCB code I've noticed that in several points core
PCB code expects that prompt_for() call will return NULL when the user
clicks the Cancel button (see action.c for example).

However in GTK HID ghid_prompt_for() is a wrapper for
ghid_dialog_input(), which returns an empty string in that case. So it
looks like PCB will sometimes execute some action even if the user click
cancel.

The fix is pretty trivial and I can submit a patch is someone can
confirm that this is really a bug.

Does lesstif's prompt_for() return NULL?

Best regards
Tomaz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH0uyMsAlAlRhL9q8RAv+4AJ4ltrAimsKSza4Ah4YoqezHbMvRrACguNgm
dv6Q41IgDwe274Ffr2uFttQ=
=Oh/Z
-----END PGP SIGNATURE-----


More information about the geda-dev mailing list