gEDA-dev: Before 1.4.0?

[Peter Clifton]

On Sat, 2008-01-19 at 20:07 +0100, Werner Hoch wrote:
> Hi Peter,
> 
> On Samstag, 19. Januar 2008, Peter Clifton wrote:
> > On Sat, 2008-01-19 at 12:43 +0000, a r wrote:
> > > On Jan 17, 2008 12:52 PM, Peter Clifton <pcjc2 at cam.ac.uk> wrote:
> > > > Fix net consolidating crash:
> > > >   Sorry, I've not yet had chance to dig deeper into whether the
> > > > "fix" I proposed is right or not. I've been on a self imposed
> > > > computer ban, leaving my laptop power adaptor at the lab until I
> > > > can learn to sleep at sensible times! (And have been otherwise
> > > > busy with work)
> > >
> > > The patch works well for me. I haven't noticed any crashes since I
> > > applied it. I haven't tested it with valgrind, though.
> >
> > Thanks for the testing... it keeps valgrind happy here. My main
> > concern was that I hadn't checked through the code paths thoroughly
> > to ensure it wouldn't cause any extra visual artifacts. Seems OK
> > though. I'll try to ensure I push something by Wednesday.
> 
> I've tested the patch to. It works fine but I'd move the patch towards 
> the creation of the lists inside the if conditions:

This is a good point. Since the o_net_consolidate_segments() call
doesn't use the "other_objects" variable, and potentially free's
pointers in that list, it should go above this call for maximum
cleanliness. Preferably just after the last call which _does_ use the
list.

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)