gEDA-dev: New slotting mechanism

[Peter TB Brett]

On Wednesday 28 November 2007 11:28:48 Bernd Jendrissek wrote:

> I don't think I'll get much more done for a little while as I have too
> much other offline stuff to do (car got stolen).  Please do look at
> the code, play with it, break it, etc., tell me you love it, or that
> it sucks.  It'll just be a while before I get to do much with the
> feedback.

The stuff in your cleanups branch looks good.  Should I merge it into the main 
repository?

(Maybe you should make a "pu" branch like Cesar has for patches which 
are "ready" -- then I can know that I'm allowed to merge them without needing 
to ask you.)

I don't have enough time to do a detailed review of your changes you've made 
in the main branch: they're just too extensive.  I'm also still not quite 
convinced that what you've done is the Right Way, and I'm a little worried 
that once it's included we'll have to support it forever even if it turns out 
not to be the Right Way.

For instance, you appear to have essentially implemented classes and signals 
in the factory/observer stuff -- I'd much rather it was implemented using 
GObject, which despite its unwieldiness is (a) well-documented, (b) 
maintained by someone else, and (c) already used extensively in gEDA anyway.

                        Peter

P.S. Your FTP server doesn't appear to anonymous access to the /pub/incoming 
directory.  This is quite normal as far as FTP server configurations go: you 
need to move them to a "proper" directory for them to become accessible.

-- 
Peter Brett

Electronic Systems Engineer
Integral Informatics Ltd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://www.seul.org/pipermail/geda-dev/attachments/20071128/230444c4/attachment-0001.pgp