gEDA-dev: [PATCH] gschem: Visual feedback for keyboard commands

[Ivan Stankovic]

On Thu, May 31, 2007 at 07:46:29PM +0100, Peter TB Brett wrote:
> +gchar *current_keyaccel_string = NULL;
> +static TOPLEVEL *saved_toplevel = NULL;
> 
> ...
> 
> +  /* We need to save the toplevel because it may not be
> +   * there anymore when we need to clear the status bar string
> +   * (this occurs with the 'fc' command, for example) */
> +  saved_toplevel = global_window_current;
> 
> 
> This is a hack.  I know the model-view-controller separation in gschem is 
> pretty rubbish, but there must be a better way to handle this without making 
> the situation even worse than it is already.  The phrase "maintenance 
> nightmare" comes to mind.

I agree, it is ugly. I removed it completely, but now when you 
press 'fw' now and then go back to the first toplevel, the string
is still there (it _will_ be cleared on the next keystroke).
But I guess this is not a big issue. Please see the attached patch.

-- 
Ivan Stankovic, ivan.stankovic at fer.hr

"Protect your digital freedom and privacy, eliminate DRM, 
learn more at http://www.defectivebydesign.org/what_is_drm"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Visual-feedback-for-keyboard-commands.patch
Type: text/x-diff
Size: 0 bytes
Desc: not available
Url : http://www.seul.org/pipermail/geda-dev/attachments/20070531/2595aab1/attachment.patch