gEDA-dev: [PATCH] gschem: clean up i_basic.c

[Ivan Stankovic]

On Tue, May 29, 2007 at 05:59:13PM +0100, Peter TB Brett wrote:
> Firstly, while you're working on this code could you please take the 
> opportunity to flesh out the Doxygen comments with \param and \returns tags?  
> It does make a lot of difference when tracing what code is supposed to do.

Will do.

> Secondly, could you elaborate on the problems you've had with stg; I may be 
> able to help...

There are two problems.

The first is, if I'm not in the root of the git repo, stg refresh fails:

[ivan at alpha2 ~/src/geda-vfeed/gschem/src] $ stg refresh
Checking for changes in the working directory... done
Refreshing patch "i_basic.c-cleanup"...error:
gschem/src/gschem/src/i_basic.c: does not exist and --remove not passed
fatal: Unable to process file gschem/src/gschem/src/i_basic.c
stg ref: Failed git-update-index

If I'm in the root, refresh works fine:

[ivan at alpha2 ~/src/geda-vfeed] $ stg refresh
Checking for changes in the working directory... done
Refreshing patch "i_basic.c-cleanup"... done
[ivan at alpha2 ~/src/geda-vfeed] $ 

The second problem is that 'stg export' does _not_ pick up changes to
gschem/include/prototype.h while 'stg show', 'git log' and 'git
format-patch' all work correctly and show the changes. 
I can't think of a reason why this happens.

-- 
Ivan Stankovic, ivan.stankovic at fer.hr

"Protect your digital freedom and privacy, eliminate DRM, 
learn more at http://www.defectivebydesign.org/what_is_drm"