gEDA-dev: [PATCH] gschem: clean up i_basic.c

Peter TB Brett peter at peter-b.co.uk
Tue May 29 12:59:13 EDT 2007


On Tuesday 29 May 2007 17:53:55 Ivan Stankovic wrote:
> On Tue, May 29, 2007 at 06:39:49PM +0200, Ivan Stankovic wrote:
> > Hi all,
> >
> > This patch removes unused code from i_basic.c, fixes some
> > comments and greatly simplifies i_show_state() function.
> > It is the first part of my visual feedback implementation.
>
> Please ignore, here is a new patch. (This time I picked
> up changes for prototype.h -- stacked git really sucks)

Hi Ivan,

Firstly, while you're working on this code could you please take the 
opportunity to flesh out the Doxygen comments with \param and \returns tags?  
It does make a lot of difference when tracing what code is supposed to do.

Secondly, could you elaborate on the problems you've had with stg; I may be 
able to help...

Thanks,

Peter

-- 
Fisher Society                              http://tinyurl.com/o39w2
CU Small-Bore Club                          http://tinyurl.com/mwrc9

      09f911029d74e35bd84156c5635688c0            peter-b.co.uk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://www.seul.org/pipermail/geda-dev/attachments/20070529/ae347601/attachment.pgp 


More information about the geda-dev mailing list