gEDA-dev: GschemDialog (work in progress)

[Ivan Stankovic]

On Tue, May 08, 2007 at 06:49:22PM +0100, Peter Clifton wrote:
> Hi all,
> 
> I thought I'd post a work-in-progress patch of an attempt at
> GschemDialog. For demonstration of added functionality, this also Ivan's
> code to save and restore dialog positions.

Wow, Peter, this is really great work! Thanks!

> A few points:
> 
> 1. It might be best to drop the "toplevel" property, as not all gschem
>    dialogs need it.

Perhaps, but it might turn out to be useful in the future.

> 2. A better interface might be to define signals, "state-save" and
>    "state-restore" which are emitted appropriately on map and unmap.
> 
>    These signals would have the benefit of abstracting the necessity to
>    chain up the mapping code, and allow dialogs to more easily overload 
>    and chain the signal handler, (or hook it with g_signal_connect).

Yes, definitely, that would be nice to have.

>    Ivan: I've not thought hard about the practicalities, but how easy is
>          it to pass a suitable pointer / object with the GKeyFile and
>          name straight into the signal handler?

I'm not quite sure what you're talking about here, but you can
pass arbitrary arguments to g_signal_emit() (see
http://developer.gnome.org/doc/API/2.0/gobject/gobject-Signals.html).

> 3. Standard GTK dialogs don't gain the extra functionality by default,
>    meaning the attached patch doesn't affect the file dialogs. Whether
>    or not that is a problem is debatable. I don't think GTK does too 
>    badly in positioning and opening its standard dialog windows.

I too think these dialogs should be left to gtk (and wm). Thanks 
again for the great work!

-- 
Ivan Stankovic, ivan.stankovic at fer.hr

"Protect your digital freedom and privacy, eliminate DRM, 
learn more at http://www.defectivebydesign.org/what_is_drm"