gEDA-dev: [PATCH] Remove code that tracks escape key presses in dialogs (bug 1710818).

[Stuart Brorson]

Ivan --

Thanks for the patches.  I'm traveling right now and can't really do
much about patches.  Howevwer, I'm certain you're doing fine work, and
I think your patch is probably OK.  Therefore, if you can have
somebody else apply it, please go ahead and do so.  If it's not
applied by early next week, then I'll do it, but if somebody does it
before me, that's OK by me.

As for a patch converting all dialogs to GtkDialog, ummm, as long as
it requires GKT 2.4 or below, it's fine with me.  If it requires > GTK
2.4, then please do it using the usual #if #else method.

Cheers,

Stuart




On Mon, 11 Jun 2007, Ivan Stankovic wrote:

> On Mon, Jun 11, 2007 at 11:15:32AM -0400, Stuart Brorson wrote:
>>> Does this get all of them? Are there any in gattrib too?
>>
>> There are plenty of <esc> callbacks in gattrib.  Please feel free to
>> edit them out.  I can't promise I will be able to get to them any time
>> soon.
>
> Stuart, it seems most of the gattrib dialogs are created by
> hand ie. not using gtk_dialog_new. This is a problem since
> the escape/delete behaviour works only for proper GtkDialogs.
>
> I've sent a patch that converts the new attribute dialog to
> be an instance of GtkDialog; the resulting code is
> much shorter and simpler. Let me know what you think.
>
> Also, would you accept a patch converting all dialogs to use
> GtkDialog?
>
> -- 
> Ivan Stankovic, ivan.stankovic at fer.hr
>
> "Protect your digital freedom and privacy, eliminate DRM,
> learn more at http://www.defectivebydesign.org/what_is_drm"
>
>
> _______________________________________________
> geda-dev mailing list
> geda-dev at moria.seul.org
> http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
>