gEDA-dev: [PATCH] Remove code that tracks escape key presses in dialogs (bug 1710818).

Ivan Stankovic ivan.stankovic at fer.hr
Mon Jun 11 12:45:57 EDT 2007


On Mon, Jun 11, 2007 at 11:15:32AM -0400, Stuart Brorson wrote:
> > Does this get all of them? Are there any in gattrib too?
> 
> There are plenty of <esc> callbacks in gattrib.  Please feel free to
> edit them out.  I can't promise I will be able to get to them any time
> soon.

Stuart, it seems most of the gattrib dialogs are created by
hand ie. not using gtk_dialog_new. This is a problem since
the escape/delete behaviour works only for proper GtkDialogs.

I've sent a patch that converts the new attribute dialog to
be an instance of GtkDialog; the resulting code is
much shorter and simpler. Let me know what you think.

Also, would you accept a patch converting all dialogs to use
GtkDialog?

-- 
Ivan Stankovic, ivan.stankovic at fer.hr

"Protect your digital freedom and privacy, eliminate DRM, 
learn more at http://www.defectivebydesign.org/what_is_drm"


More information about the geda-dev mailing list