gEDA-dev: [PATCH] Remove code that tracks escape key presses in dialogs (bug 1710818).

Ivan Stankovic ivan.stankovic at fer.hr
Mon Jun 11 11:49:38 EDT 2007


On Mon, Jun 11, 2007 at 04:05:04PM +0100, Peter Clifton wrote:
> Does this get all of them? Are there any in gattrib too? If not, this
> presumably wipes out:
> 
> [ 1710818 ] Redundant code to close dialogs with "Escape" key
> http://sourceforge.net/tracker/index.php?func=detail&aid=1710818&group_id=161080&atid=818426

I've only looked at gschem, but I'll take a look at gattrib too.

> I see you removed the "return" handler in the print dialog code, and
> changed the way buttons are added (causing the print button to grab
> focus).
> 
> Can this be done more simply with:
> 
> 
> void                gtk_dialog_set_default_response     (GtkDialog *dialog,
>                                                          gint response_id);

Nope, that doesn't work (this is already being called in the original
code just before gtk_dialog_run). I don't know why, but I could only get
the focus on the print button by explicitly calling
gtk_widget_grab_focus.

> Another superb patch,

Thanks!

-- 
Ivan Stankovic, ivan.stankovic at fer.hr

"Protect your digital freedom and privacy, eliminate DRM, 
learn more at http://www.defectivebydesign.org/what_is_drm"


More information about the geda-dev mailing list