gEDA-dev: [PATCH] Remove code that tracks escape key presses in dialogs (bug 1710818).

Peter Clifton pcjc2 at cam.ac.uk
Mon Jun 11 11:05:04 EDT 2007


On Mon, 2007-06-11 at 14:52 +0200, Ivan Stankovic wrote:
> Since GTK takes care of escape key presses, this code
> is not needed.

Looks good - I never had time to fix that one yet!


Does this get all of them? Are there any in gattrib too? If not, this
presumably wipes out:

[ 1710818 ] Redundant code to close dialogs with "Escape" key
http://sourceforge.net/tracker/index.php?func=detail&aid=1710818&group_id=161080&atid=818426


I see you removed the "return" handler in the print dialog code, and
changed the way buttons are added (causing the print button to grab
focus).

Can this be done more simply with:


void                gtk_dialog_set_default_response     (GtkDialog *dialog,
                                                         gint response_id);

Sets the last widget in the dialog's action area with the given
response_id as the default widget for the dialog. Pressing "Enter"
normally activates the default widget.


Another superb patch,

Best regards,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



More information about the geda-dev mailing list