gEDA-dev: [PATCH] gschem: Visual feedback for keyboard commands

[Ivan Stankovic]

On Fri, Jun 01, 2007 at 09:33:31PM -0400, Ales Hvezda wrote:
> >with the behaviour, and this patch certainly isn't for CVS. 
> >For example, see what happens when you press the return key several
> >times. It floods the entire status bar with a 'ReturnReturn..." string.
> >
> >Would a static global counter be acceptable to solve this problem? :)
> 
> 	I don't know if Peter's guile callback suggestion will solve
> this problem, but it is something to consider.

I can't see how it would solve the problem. And guile never gets
modifier keys...

> 	And you might consider limiting the key name text to a fixed
> number of characters (say 10-15).  If the allocation of characters
> fills up (or you cannot display the entire keyname), clear it, and then
> add more.

I just did that (the limit is set at 10 chars, I guess that's
reasonable) and it works good. Please test the attached patch.
(Note that I'm more interested in cases where the keyboard command
does _not_ correspond to a valid action, since the valid commands work
perfectly)

> PS. About the use of static variables, be careful, the user can open up
> multiple windows and I just observed the same key name string in two
> different toplevel windows (when I only typed it in one of them).

I can't reproduce this. How did you get the same string in two
different windows?

-- 
Ivan Stankovic, ivan.stankovic at fer.hr

"Protect your digital freedom and privacy, eliminate DRM, 
learn more at http://www.defectivebydesign.org/what_is_drm"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Visual-feedback-for-keyboard-commands.patch
Type: text/x-diff
Size: 4221 bytes
Desc: not available
Url : http://www.seul.org/pipermail/geda-dev/attachments/20070603/99a59221/attachment.patch