gEDA-dev: [PATCH 1/3] gattrib: move menu callbacks to x_window.c

Stuart Brorson sdb at cloud9.net
Sun Jul 22 14:25:43 EDT 2007


Ivan --

Thanks for the new patches.   I applied them and they seem to work
fine.

One minor thing:  I notice you've been removing some of my
comments like this:

-/* ========================================================= *
- * new attrib dialog widgets
- * ========================================================= */

I realize that different people have different ways to comment their
code, and many are reasonable.  Also, there is no gEDA standard for
coding comments.  But since I often code using a non-colorized version
of emacs, I prefer to have function definitions clearly separated by
long lines like this:

/* ========================================================= */

That way I can find my way around in the code.  Therefore, please
don't remove the separators.

However, don't bother to put the /* ===== */ which you removed back in
.... it's not that big a deal.  I might just do it at the code sprint,
once I get my git issues worked out.

Finally, changing the comments to DOxygen
comments is a good idea.  Thank you!

Cheers,

Stuart


More information about the geda-dev mailing list