gEDA-dev: [PATCH] gattrib: reorganize file opening code

Ivan Stankovic ivan.stankovic at fer.hr
Wed Jul 18 05:05:01 EDT 2007


Hi,

Here is the first patch in my patch series meant
to simplify/improve/fix gattrib. This patch is 
moderately intrusive and hasn't had extensive testing.
As such, I would not consider it to be merged
without testing it a bit more (it appears to work
fine for me though). So please give it a try and
report any issues. 

Hopefully the patch should resolve (or help resolve) 
couple of gattrib related bugs in the tracker.

One thing I'm not sure about is the behaviour
when the user has already opened several pages
and then the File->Open is invoked to open another
schematic (project?). I would much rather see 
this as a request to close the current project,
destroy all the data (SHEET_DATA etc.) and reinitialize
everything with the new project. (See my comments
to the s_toplevel_menubar_file_open function.)
Stuart, what do you think?

-- 
Ivan Stankovic, ivan.stankovic at fer.hr

"Protect your digital freedom and privacy, eliminate DRM, 
learn more at http://www.defectivebydesign.org/what_is_drm"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gattrib-reorganize-file-opening-code.patch
Type: text/x-diff
Size: 39352 bytes
Desc: not available
Url : http://www.seul.org/pipermail/geda-dev/attachments/20070718/793bf1b8/attachment-0001.patch 


More information about the geda-dev mailing list