gEDA-dev: Gschem crash in compselect

Peter Clifton pcjc2 at cam.ac.uk
Sat Aug 11 21:03:57 EDT 2007


On Sat, 2007-08-11 at 22:07 +0100, Peter Clifton wrote:
> This is difficult to reproduce, probably because its a race with a
> timer.

Ok, easily reproducible if you type fast!

If you type two or more characters into the filter box, and close the
compselect dialog within 300ms of the penultimate character, there was
still a timer running which didn't get cancelled.

Fixed in git: fa2045b8e9cac268fe0c0b7af2028ea768c8e465

We now cancel any pending timer as new ones are added. This does make
the filtering appear to pause if you type quicker than the timers
expire. I've changed the timer from 300ms to 200ms to compensate:

Fixed in git: 802a2fea15d9bd918bd2398ac06bf6ca9b2e75c4

And finally, the filtering broke completely after pressing the "Refresh"
button on the component selector.

Fixed in git: e04284b595dffa4b9931872ae33b76daede58dd7


Please test, and if you find any more crashes / strange behaviour with
the component selector, please let me know!

Regards,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



More information about the geda-dev mailing list