gEDA-dev: Filechooser and component selector code

[Peter C.J. Clifton]

On Sep 3 2006, Patrick Bernaud wrote:

>Hi Peter,
>
>Peter C.J. Clifton writes:
> > Hi,
> > 
> > I'm continuing work to split the component selector away from the 
> > file-chooser code in gschem. This will allow more divergence between 
> > those functions, and ought to allow better abstracted GTK+ programming.
> > 
>
>Just curious, what have you got against my own split of component and
>file selectors? See the mails we exchanged in the end of July.

I do appologise, and will admit to forgetting the state of work already 
underway. Stupid on my part given I actually have your code here somewhere!

I was aware of your work on the preview widget for the file-chooser, and 
was hoping it would enter CVS soon. I hadn't remembered that you'd 
separated out and re-written the component selector.

> > 3. Consider re-writing x_fileselect.c to better abstract gschem 
> > operations from the GTK+ code.
>
>Mmh could you tell us more on this one?

Mainly I was thinking of the pieces of code in x_fileselect.c which 
actually perform actions such as loading and closing gschem's pages. My 
impression of the code (especially the old dialogs), was that too much 
interaction was gschem specific, ie. harder to re-use the same code in 
gattrib, or others. I'm not at my own computer, so without the sourcecode 
its harder to pinpoint what I'm refering to.

>Plus the two dialogs are ready for a preview as a GtkWidget. In fact
>they are already using one, roughly encapsulating a TOPLEVEL.


Could I ask if you would be willing to split out your component selector, 
fileselector and preview widget work as a patch against CVS head? I'd like 
to see it applied so I can spend some time tinkering with the layout of the 
component selector. (The impetus for my own patch to separate the two). 
Eventually I hope to trial different GUIs for a parts manager, but time may 
not permit this.

If you want more testing of it before CVS committing, we can get some 
people using it here.

Regards

Peter Clifton