gEDA-dev: Problems with component selector

[Carlos Nieves Ónega]

Hi,

El lun, 23-10-2006 a las 22:50 +0200, Carlos Nieves Ónega escribió:
> Hi,
> I have a problem with the component selector, which affects CVS HEAD and
> the last geda/gaf release. Steps to reproduce it:
>  - Run gschem.
>  - Open the component selector, and select one component (7400-1.sym).
>  - Go to the gschem's window and place one there. 
>  - Back to the component selector, click the Cancel button.
>  - Back to gschem, you can still place components. Hit the escape key.
>  - Open the component selector again, and select the same component as
> before (7400-1.sym).
>  - Go to gschem's window: the component is not drawn.
>  - Hit the apply button in the component selector and go back to
> gschem's window: the component is not drawn.
>  - If I click on the gschem's window several times (to see if it is a
> drawing problem), then click the cancel button of the component
> selector, and afterwards do a view->redraw. No new component is shown.

It seems the problem is in x_compselect.c, function
x_compselect_callback_response:

[snip]
if (toplevel->current_clib == NULL ||
     g_ascii_strcasecmp (toplevel->current_clib, directory) != 0 ||
     toplevel->current_basename == NULL ||
     g_ascii_strcasecmp (toplevel->current_basename, component) != 0) {
  [redraw component]
}

The problem is that the second time, both toplevel->current_clib and
toplevel->current_basename are the same, so the redrawing code is not
executed.

The attached patch seems to work for me.

Regards,

Carlos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x_compselect_20061024.diff
Type: text/x-patch
Size: 2266 bytes
Desc: not available
Url : http://www.seul.org/pipermail/geda-dev/attachments/20061024/c3ddad02/x_compselect_20061024.bin