gEDA-dev: Fix for bug #1527465: zoom extents when window is maximised

[Carlos Nieves Ónega]

Hi,

El vie, 06-10-2006 a las 10:39 +0200, Patrick Bernaud escribió:
[snip]
> They really have to be incremental, as small as possible, one feature
> at a time and to concern as few places as possible at once. And I do
> not think it has been the case with these patches. Hence my comments.

As I stated before, I will try to do it better in the future. My opinion
was and is the same as yours. In this case we only differ on what a
feature is.

[snip]
>  > It's easy to revert to the previous state, since the last three commits
>  > to gschem and libgeda are because of your 3 patches committed. 
> 
> You mean with 'cvs admin -o'? It requires admin priviledge on the
> server that I doubt I have been granted. Plus it is dangerous and
> would require every people the check out again or we will face serious
> troubles.

I am with Dan here. I don't like to change the CVS history.

[snip]
>  > The function x_event_window_state was deleted when committing your
>  > patch, thus removing the definition from prototype.h and unconnecting
>  > the signal in x_window.c. Result: the previous fix was deleted.
> 
> No it is still in the history of x_event.c and there is no mention
> anywhere (ChangeLog and history of x_event.c) that it has been
> removed and why.

That's true. Then we can improve the change description in the
ChangeLog.

For me the ChangeLog is yet another file in CVS. If it needs to be
improved to better explain the changes made, or to correct some entry,
(even if it does not imply to change any other file), I think it should
be done.

[snip]
>  > [...]
>  > I didn't modify the date. It was always the right one (october, 4th).
>  > I meant that, before the commitment, the ChangeLog looked like:
> 
> See message <20061004201140.9AA751408042 at moria.seul.org> from
> geda-cvs:
> >>>>
>   --- ChangeLog	4 Oct 2006 19:10:29 -0000	1.521
>   +++ ChangeLog	4 Oct 2006 20:11:40 -0000	1.522
>   @@ -1,4 +1,16 @@
>   -2006-10-03  Patrick Bernaud  <b-patrick at wanadoo.fr>
>   +2006-10-04  Patrick Bernaud  <b-patrick at wanadoo.fr>

Indeed. Sorry. I didn't notice this when committing.

In the future, I should note this in the ChangeLog too, and commit this
change alone. Right?

[snip]
> My purpose is to say what can be better done, propose changes for the
> future and improve things ... or at least discuss how we can do that.

Mine too.

I thought your patches were great, and liked them so much that I made
the future became true sooner than you expected.

We agree that changes should be done incrementally and one by one.

My thought of the patch was: "substitute the previous x_event
window_state bug fix by the new x_event_configure Patrick's one".
You divided this into two steps: delete the previous fix and commit the
new one. 

ok. In the future I'll try to divide the patches as much as possible. 

Thanks for your comments,

Carlos