gEDA-dev: Fix for bug #1527465: zoom extents when window is maximised

Carlos Nieves Ónega cnieves.mail at gmail.com
Wed Oct 4 18:05:19 EDT 2006


Hi Patrick,

El mié, 04-10-2006 a las 23:51 +0200, Patrick Bernaud escribió:
> Hi Carlos,
> 
> Carlos Nieves Ónega writes:
>  > Hi Patrick,
>  > I commited these valuable changes into CVS. Thank you for looking at
>  > this.
> 
> Just a quick note: if I posted these three 'macro' patches yesterday
> it was more to ask for comments and ideas and help chasing the obvious
> bugs I left rather than for straight commit.

I know. I reviewed them, they looked nice, and I thought they were good
enough to be committed. If there is a problem, we can always go back...

Talking about the zoom extents when maximizing patch, since I was the
one who made the first version of it, I feel I was the right person to
decide about it...

> Moreover I take great care with having incremental, progressive
> changes. For example in this particular case, each of these changes
> is the result of two logical smaller changes (that I manage locally
> with bzr and commit to CVS when ready, see the ones for the compselect
> and fileselect dialog).
> 
> In my mind it is of a primary importance to clearly separate and
> document each and every modification. It really helps tracking and
> identifying the future inevitable problems as well as reviewing what
> has really been modified, how and why.

It also helps reviewing :-)

Thanks,

Carlos



More information about the geda-dev mailing list