gEDA-dev: Other valgrind output

[Peter Clifton]

A minor point.. can't cause a crash, but might about one in 2^(number of bits in integer) times cause the preview widget to start enabled rather than disabled.

==18659== Conditional jump or move depends on uninitialised value(s)
==18659==    at 0x808D2E5: x_fileselect_preview_checkbox (x_fileselect.c:639)
==18659==    by 0x436EB75: g_cclosure_marshal_VOID__VOID (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x4356F68: g_closure_invoke (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x436D590: signal_emit_unlocked_R (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x436E4C3: g_signal_emit_valist (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x436E785: g_signal_emit (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x4664781: gtk_toggle_button_clicked (in /usr/lib/libgtk-x11-2.0.so.0.800.19)
==18659==    by 0x436EB75: g_cclosure_marshal_VOID__VOID (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x4357298: g_type_class_meta_marshal (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x4356F68: g_closure_invoke (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x436CE85: signal_emit_unlocked_R (in /usr/lib/libgobject-2.0.so.0.1000.3)
==18659==    by 0x436E4C3: g_signal_emit_valist (in /usr/lib/libgobject-2.0.so.0.1000.3)

Untested fix:

f_current->preview_control = TRUE;

or 

f_current->preview_control = FALSE;

at some point in void x_fileselect_setup_old (...), before the call to 

gtk_signal_connect (GTK_OBJECT(f_current->preview_checkbox),
                    "toggled", GTK_SIGNAL_FUNC(x_fileselect_preview_checkbox),
                     f_current);


This would keep valgrind happy!

Peter