gEDA-dev: Re: PCB: Graphical bugs

[ldoolitt at recycle.lbl.gov]

DJ -

On Thu, Jul 13, 2006 at 06:34:03PM -0400, DJ Delorie wrote:
> 
> > Patch appended.  "It Works For Me" [TM].
> 
> Unfortunately, the core isn't supposed to know about screen layout.
> The correct fix would be to find the draw_rect hooks in the two gui
> HIDs (gtk and lesstif) and make sure they work correctly in all cases.

I thought you might say that.  But at least now everyone knows
where that visual defect comes from, and can talk about the proper
way to fix it.  It took me hours just to get to that level.

Do you see anything like this with lesstif?

The right fix might just be a pair of ordering steps
in hid/gtk/gtkhid-main.c:ghid_draw_rect().

Maybe we should then drop the redundant min/max computation in
src/crosshair.c:DrawAttached()?

If what you say about "know[ledge] about screen layout" is correct,
does that mean that the other two uses of Settings.ShowSolderSide
in src/crosshair.c are bugs?  One in particular looks very suspicious.

    - Larry