gEDA-dev: Add pin wierdness in gschem

Patrick Bernaud b-patrick at wanadoo.fr
Fri Dec 15 11:45:31 EST 2006


Carlos Nieves Ónega writes:
 > [...]
 > Now the backend needs to know the OBJ_* definitions which are in
 > libgeda/include/o_type.h . By now, I included the definitions in the
 > backend, however I think they should be in libgeda.
 > If no one objects, I will move them into libgeda...

Please consider using symbols instead of strings for this particular
function as well as other like g_get_object_bounds().

BTW I have learned something today: it looks like it is possible to
add functions inside functions in C. Is it standard?

Anyway, to me, possible does not mean clean. Why not having this
custom function out of g_get_object_bounds() and declared static as it
has been done so far everywhere else in the code?


Patrick



More information about the geda-dev mailing list