gEDA-bug: [ geda-Bugs-1679831 ] Renumbers from 101 even when --pgskip not used

[SourceForge.net]

Bugs item #1679831, was opened at 2007-03-13 19:46
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1679831&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: TCPIP (cptarun)
Assigned to: Nobody/Anonymous (nobody)
Summary: Renumbers from 101 even when --pgskip not used

Initial Comment:
The script should renumber starting from 1 when there is just one schematic file and --pgskip is not used. But it does not do this; it renumbers from 101 even in such cases.

The fix for this is to delete one line (line 52 in
v1.4) which says

unless( $pgskip ) { $pgskip = 100; }

This line should not be present. Because of the presence
of this line, $pgskip is never undefined. Later on in the script (line 98 in v1.4) there is this code:

if( ! $devcnt{$pre} ) { $devcnt{$pre} = $pgskip ? ($i+1)*$pgskip : 0; }

This code tests whether $pgskip is defined, and this
test will always return true because you are forcefully
defining the variable above where it should be left
undefined.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1679831&group_id=161080