gEDA-bug: [ geda-Bugs-1730478 ] gschem crash in recent_files_add

[SourceForge.net]

Bugs item #1730478, was opened at 2007-06-03 20:52
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1730478&group_id=161080

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: gschem
Group: CVS
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ben Jackson (bjj)
Assigned to: Nobody/Anonymous (nobody)
Summary: gschem crash in recent_files_add

Initial Comment:
recent_files_add starts at global_window_current and walks back through 'prev' as far as it can.  In my crash, lobal_window_current looks fine, its 'prev' looks fine (like a suitable pointer) but the contents of THAT are garbage, which causes a crash in a GTK sanity check.

This seems to be due to s_toplevel_init() creating exactly that:  A toplevel with the only initialized fields being wid, next, prev.

I don't really know what was intended, but I see a few solutions:

1)  Have recent_files_add ignore wid==-1 toplevels, or

2)  If people are doing this everywhere, just change s_toplevel_init to call g_new0().

I just tested (1), I will probably throw in (2) just to be safe.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=818426&aid=1730478&group_id=161080