gEDA-dev: Page list changes, toplevel overhaul (incl. large cleanups)

[Peter Clifton <pcjc2@xxxxxxxxx>]

Dear all,

I'm pleased to have (nearly) completed the cleanup I started which moves
many gschem specific variables out of TOPLEVEL, and into a new structure
GSCHEM_TOPLEVEL. This is passed as a "GSCHEM_TOPLEVEL *w_current"
parameter in all gschem functions which previously took a TOPLEVEL *.

The patch series renames any "TOPLEVEL *w_current" in libgeda to
"TOPLEVEL *toplevel", and this distinction is drawn through libgeda and
gschem.

You'll also notice many other cleanups in the patch series relating to
unused code, duplicated code, and un-necessary use of global variables.

Oh.. and in conjunction with the page list updates (which I've tested
much more extensively than the newer stuff), it kills two more linked
lists (the PAGE linked list, and the TOPLEVEL linked list).


Please take a look at:
http://repo.or.cz/w/geda-gaf/pcjc2.git?a=shortlog;h=toplevel_overhaul2


I look forward to people's comments.


We might not want to commit:
'Add page list "changed" signal handler to gschem's page manager dialog.'

It doesn't bring any benefits yet. We still have to manually update the
page manger every time we switch to a different page, so we don't gain
much by being notified of changes to the page list.


For clarity, some commits which logically should be merged together are
still separate. This is basically a throw-back to the break-it, then
fix-it method used in producing the patches.

'Remove all pointers to GTK widgets from the TOPLEVEL structure'
'Fix libgeda's use of the removed TOPLEVEL variables'
'Fix gschem's use of the removed TOPLEVEL variables'


Best Regards,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev