Re: gEDA-dev: Ivan's gattrib patches

[Peter Clifton <pcjc2@xxxxxxxxx>]

On Wed, 2007-08-01 at 22:52 +0200, Ivan Stankovic wrote:
> On Wed, Aug 01, 2007 at 09:46:31PM +0100, Peter Clifton wrote:
> > Another minor issue...
> > 
> > I probably missed the reasoning behind this, but why does File->Open now
> > result in an unimplemented feature warning? From my basic poking, it
> > appeared to work before.
> 
> _Appeared_ is the key here. Stuart and I agreed that the semantics
> is unclear, and the original implementation was... let's just say
> that I'm amazed that it worked at all. I think the relevant discussion
> is in the archives.
> 
> (I do intend to fix that in the future, but I really can't tell
> when that will be.)

Sounds fine to me. I did notice that if you "escape" cancelled out of
the file->open box, all manner of GObject type warnings and spew would
occur.

I'd imagine File->Open would close the files you have open right now,
and then allow you to open a new one (or multiple).

Ivan - could you take a quick look at the git repo at:
http://repo.or.cz/w/geda-gaf/pcjc2.git
and see if you're still happy with the patches (and my odd change here
and there).

Also - what are your thoughts with regards the set_cell function, and
possibly removing the rest of that related code. (Or leaving it all?)


I'm keen to get some / all of these pushed into the main repo, if only
so we can all keep working without having to rebase all the time.

I found the trigger (and fix) for the confirm quit bug. The signal
handler didn't return TRUE from the "delete-event" handler to cancel the
default action of destroying the window.

A second signal handler connected to the GtkObject's "delete" signal was
superfluous, and caused the second confirmation to appear (and be
ignored) a second time.

Regards,

-- 
Peter Clifton

Electrical Engineering Division,
Engineering Department,
University of Cambridge,
9, JJ Thomson Avenue,
Cambridge
CB3 0FA

Tel: +44 (0)7729 980173 - (No signal in the lab!)



_______________________________________________
geda-dev mailing list
geda-dev@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev