Re: gEDA: PCB creeping feature addition suggestion

[Karel Kulhavý <clock@twibright.com>]

On Tue, Aug 24, 2004 at 10:05:06PM -0400, Dan McMahill wrote:
> On Fri, Aug 20, 2004 at 11:43:23AM +0000, Karel Kulhav? wrote:
> > Hello
> > 
> > It's obviously a hard problem to determine footprint= attribute for
> > a part arbitrarily chosen from PCB library.
> > 
> > I suggest (in the spirit of creeping-featurism ;-) ) a feature addition into
> > PCB: that the pcb-bin-library window would have a third column that would
> > display the necessary footprint= attribute for the given part. Macro aatributes
> > in the style "DIL 16 300" would have a description in the style of "DIL <number
> > of pins> <distance between rows in mils>"
> > 
> 
> something like:
> 
> 
> Index: file.c
> ===================================================================
> RCS file: /cvsroot/pcb/pcb/src/file.c,v
> retrieving revision 1.16
> diff -u -2 -r1.16 file.c
> --- file.c      30 Apr 2004 01:49:21 -0000      1.16
> +++ file.c      25 Aug 2004 01:55:58 -0000
> @@ -940,10 +940,12 @@
>           /* create the list entry */
>           len = strlen (EMPTY (entry->Value)) +
> -           strlen (EMPTY (entry->Description)) + 3;
> +           strlen (EMPTY (entry->Description)) +
> +           strlen (EMPTY (entry->Package)) + 6;
>           entry->ListEntry = MyCalloc (len, sizeof (char),
>                                        "ReadLibraryDescription()");
>           sprintf (entry->ListEntry,
> -                  "%s, %s", EMPTY (entry->Value),
> -                  EMPTY (entry->Description));
> +                  "%s, %s [%s]", EMPTY (entry->Value),
> +                  EMPTY (entry->Description),
> +                  EMPTY (entry->Package));
>         }
>      }

What version is this patch for and how do I apply it? It won't apply for
me:

clock@beton:~/pcb-20040530$ patch < ../patch 
can't find file to patch at input line 8
Perhaps you should have used the -p or --strip option?
The text leading up to this was:
--------------------------
|Index: file.c                                                                  
   
|===================================================================            
   
|RCS file: /cvsroot/pcb/pcb/src/file.c,v                                        
   
|retrieving revision 1.16                                                       
   
|diff -u -2 -r1.16 file.c                                                       
   
|--- file.c      30 Apr 2004 01:49:21 -0000      1.16                           
   
|+++ file.c      25 Aug 2004 01:55:58 -0000                                     
   
--------------------------
File to patch: src/file.c
patching file src/file.c
Hunk #1 FAILED at 940.
1 out of 1 hunk FAILED -- saving rejects to file src/file.c.rej

Cl<
> 
> works pretty well for the m4 libs which don't make use of the
> Param1 and Param2 defines.  Libs which work well with this are:
> 
> ~amp
> ~amphenol
> ~bourns
> ~cts
> ~geda
> ~johnstech
> ~minicircuits
> ~panasonic
> 
> The other ~* libs don't work so well.  
> 
> these are
> 
> ~connector
> ~crystal
> ~generic
> ~genericsmt
> ~jerry
> ~linear
> ~logic
> ~lsi
> ~memory
> ~optical
> ~pci
> ~resistor_0.25W
> ~resistor_adjust
> ~resistor_array
> ~texas_inst_amplifier
> ~texas_inst_voltage_reg
> ~transistor
> 
> -Dan
>